Skip to content

[OSDOCS#18986] CQA pre-migration for Authentication index and Understanding identity provider assemblies#115739

Open
maxwelldb wants to merge 1 commit into
openshift:mainfrom
maxwelldb:osdocs-18986-authentication-index
Open

[OSDOCS#18986] CQA pre-migration for Authentication index and Understanding identity provider assemblies#115739
maxwelldb wants to merge 1 commit into
openshift:mainfrom
maxwelldb:osdocs-18986-authentication-index

Conversation

@maxwelldb

@maxwelldb maxwelldb commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Version(s): 4.20+

Issue: OSDOCS-18986

Link to docs preview: 4.20+

QE review:

  • QE has approved this change.

Additional information: Combines #115740 (identity provider nav module) since its anchor rename is referenced by this PR's module. Xrefs allowed per the index.adoc navigation-file exception; nav modules are single-use.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 17, 2026
@maxwelldb
maxwelldb force-pushed the osdocs-18986-authentication-index branch from c6011b6 to 669d3a3 Compare July 17, 2026 21:39
@maxwelldb

Copy link
Copy Markdown
Contributor Author

/test all

Comment thread modules/authentication-about-authentication.adoc Outdated
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc
@maxwelldb
maxwelldb marked this pull request as ready for review July 18, 2026 23:22
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2026
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc Outdated
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authentication.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
Comment thread modules/authentication-about-authorization.adoc
maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request Jul 19, 2026
Renaming this PR's anchor to supported-identity-providers_{context}
broke the only other in-repo reference to it, in
authentication/index.adoc, which was still on the pre-rename anchor
name. ci/prow/validate-portal was failing with:
'Unknown ID or title "supported-identity-providers", used as an
internal cross reference'. Update the target so this PR builds clean
independent of merge order with openshift#115739.
Comment thread modules/authentication-about-authentication.adoc
@maxwelldb
maxwelldb force-pushed the osdocs-18986-authentication-index branch from 2d4e22e to 8bfa4a5 Compare July 19, 2026 01:25
@maxwelldb maxwelldb changed the title [OSDOCS#18986] CQA pre-migration for Authentication and authorization index assembly [OSDOCS#18986] CQA pre-migration for Authentication index and Understanding identity provider assemblies Jul 19, 2026
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc
Comment thread modules/identity-provider-supported-types.adoc

| xref:../authentication/understanding-authentication.adoc#understanding-authentication[Manage authentication]
| xref:../authentication/understanding-identity-provider.adoc#supported-identity-providers[Supported identity providers]
| xref:../authentication/understanding-identity-provider.adoc#supported-identity-providers_understanding-identity-provider[Supported identity providers]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.ConceptLink: Move all links and cross references to Additional resources.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to keep the reference current. Resolving this error is out of scope for this PR.

@dfitzmau dfitzmau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @maxwelldb . Would you be OK to squash the commits?

// This file is a navigation file - xrefs are allowed in this type of module, but it must only ever be included from one location

:_mod-docs-content-type: REFERENCE
[id="authentication-overview_{context}"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For easier reference tags, should the filename and ID be identical? Check other files for the same.

@dfitzmau dfitzmau removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 20, 2026
@maxwelldb
maxwelldb force-pushed the osdocs-18986-authentication-index branch from e15a058 to 10d2152 Compare July 20, 2026 15:29
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants